9eb0784f6f
Previously, we were returning redundant member count updates or encrypted
device updates from the /sync endpoint in some cases. The extra member
count updates are spec-compliant, but unnecessary, while the extra
encrypted device updates violate the spec.
The refactor necessary to fix this bug is also necessary to support
filtering on state events in sync.
Details:
Joined room incremental sync needs to examine state events for four
purposes:
1. determining whether we need to return an update to room member counts
2. determining the set of left/joined devices for encrypted rooms
(returned in `device_lists`)
3. returning state events to the client (in `rooms.joined.*.state`)
4. tracking which member events we have sent to the client, so they can
be omitted on future requests when lazy-loading is enabled.
The state events that we need to examine for the first two cases is member
events in the delta between `since` and the end of `timeline`. For the
second two cases, we need the delta between `since` and the start of
`timeline`, plus contextual member events for any senders that occur in
`timeline`. The second list is subject to filtering, while the first is
not.
Before this change, we were using the same set of state events that we are
returning to the client (cases 3/4) to do the analysis for cases 1/2.
In a compliant implementation, this would result in us missing some
relevant member events in 1/2 in addition to seeing redundant member
events. In current conduwuit this is not the case because the set of
events that we return to the client is always a superset of the set that
is needed for cases 1/2. This is because we don't support filtering, and
we have an existing bug[1] where we are returning the delta between
`since` and the end of `timeline` rather than the start.
[1]: https://github.com/girlbossceo/conduwuit/issues/361
Fixing this is necessary to implement filtering because otherwise
we would start missing some member events for member count or encrypted
device updates if the relevant member events are rejected by the filter.
This would be much worse than our current behavior.
|
||
|---|---|---|
| .gitea | ||
| .github/workflows | ||
| .gitlab | ||
| bin | ||
| debian | ||
| docs | ||
| nix/pkgs | ||
| src | ||
| tests | ||
| .dockerignore | ||
| .editorconfig | ||
| .envrc | ||
| .git-blame-ignore-revs | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| audit.toml | ||
| book.toml | ||
| Cargo.lock | ||
| Cargo.toml | ||
| clippy.toml | ||
| CODE_OF_CONDUCT.md | ||
| conduwuit-example.toml | ||
| CONTRIBUTING.md | ||
| default.nix | ||
| engage.toml | ||
| flake.lock | ||
| flake.nix | ||
| LICENSE | ||
| README.md | ||
| renovate.json | ||
| rust-toolchain.toml | ||
| rustfmt.toml | ||
conduwuit
main / stable: 
a very cool, featureful fork of Conduit
Visit the Conduwuit documentation for more information.
What is Matrix?
Matrix is an open network for secure and decentralized communication. Users from every Matrix homeserver can chat with users from all other Matrix servers. You can even use bridges (also called Matrix Appservices) to communicate with users outside of Matrix, like a community on Discord.
What is the goal?
An efficient Matrix homeserver that's easy to set up and just works. You can install it on a mini-computer like the Raspberry Pi to host Matrix for your family, friends or company.
Can I try it out?
An official conduwuit server ran by me is available at transfem.dev (element.transfem.dev / cinny.transfem.dev)
transfem.dev is a public homeserver that can be used, it is not a "test only homeserver". This means there are rules, so please read the rules: https://transfem.dev/homeserver_rules.txt
transfem.dev is also listed at servers.joinmatrix.org
What is the current status?
conduwuit is a hard fork of Conduit which is in beta, meaning you can join and participate in most Matrix rooms, but not all features are supported and you might run into bugs from time to time.
Contact
If you run into any question, feel free to
- Ask us in
#conduwuit:puppygock.gayon Matrix - Open an issue on GitHub
Donate
- Liberapay: https://liberapay.com/girlbossceo
- Ko-fi: https://ko-fi.com/puppygock
- GitHub Sponsors: https://github.com/sponsors/girlbossceo
Logo
Original repo and Matrix room picture was from bran (<3). Current banner image and logo is directly from this cohost post.
Is it conduwuit or Conduwuit?
Both, but I prefer conduwuit.
Mirrors of conduwuit
- GitHub: https://github.com/girlbossceo/conduwuit
- GitLab: https://gitlab.com/conduwuit/conduwuit
- git.girlcock.ceo: https://git.girlcock.ceo/strawberry/conduwuit
- git.gay: https://git.gay/june/conduwuit
- Codeberg: https://codeberg.org/girlbossceo/conduwuit
- sourcehut: https://git.sr.ht/~girlbossceo/conduwuit