mirrors/conduwuit
1
0
Fork 0
mirror of https://github.com/girlbossceo/conduwuit.git synced 2025-12-11 09:48:49 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove pointless and buggy *_visibility in-memory caches

Browse source 
Signed-off-by: June Clementine Strawberry <june@3.dog>
This commit is contained in:
June Clementine Strawberry 2025-04-02 22:38:47 -04:00
parent 1b71b99c51
commit ea246d91d9
No known key found for this signature in database
5 changed files with 10 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/service/rooms/state_accessor/server_can.rs
View file

@ -1,4 +1,4 @@
use conduwuit::{error, implement, utils::stream::ReadyExt};
use conduwuit::{debug_info, implement, utils::stream::ReadyExt};
use futures::StreamExt;
use ruma::{
EventId, RoomId, ServerName,
@ -22,15 +22,6 @@ pub async fn server_can_see_event(
return true;
};
if let Some(visibility) = self
.server_visibility_cache
.lock()
.expect("locked")
.get_mut(&(origin.to_owned(), shortstatehash))
{
return *visibility;
}
let history_visibility = self
.state_get_content(shortstatehash, &StateEventType::RoomHistoryVisibility, "")
.await
@ -44,7 +35,7 @@ pub async fn server_can_see_event(
.room_members(room_id)
.ready_filter(|member| member.server_name() == origin);
let visibility = match history_visibility {
match history_visibility {
| HistoryVisibility::WorldReadable | HistoryVisibility::Shared => true,
| HistoryVisibility::Invited => {
// Allow if any member on requesting server was AT LEAST invited, else deny
@ -62,12 +53,5 @@ pub async fn server_can_see_event(
error!("Unknown history visibility {history_visibility}");
false
},
};
self.server_visibility_cache
.lock()
.expect("locked")
.insert((origin.to_owned(), shortstatehash), visibility);
visibility
}
}